Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luks_device: make key add/removal idempotent #19

Closed
felixfontein opened this issue Apr 5, 2020 · 2 comments · Fixed by #168
Closed

luks_device: make key add/removal idempotent #19

felixfontein opened this issue Apr 5, 2020 · 2 comments · Fixed by #168

Comments

@felixfontein
Copy link
Contributor

SUMMARY
  • The new_keyfile currently adds a new key, no matter whether the key is already present or not.
  • The remove_keyfile currently dies when the key is not present.

To implement this properly (especially with #52371, allow_to_remove_last_key, in mind), we need a mechanism which can detect if a key is already there. If the device is closed, one could try to open it (and on success close it again); that would probably be an acceptable hack. That doesn't work when the device is already open, though.

(Migration of ansible/ansible#52409; existing PR ansible/ansible#65937, CC @mulatinho)

COMPONENT NAME

luks_device

ISSUE TYPE
  • Feature Idea
@felixfontein
Copy link
Contributor Author

@mulatinho would be great if you could migrate the PR to this collection! If you need help, just ask :)

@mulatinho
Copy link

@felixfontein hey! lots of things changed here :D I really want to participate more, I think now I am fully established on my new company and probably I will have more time! I will try to see how things are working now here and try finally work more on the group, thanks for reminder me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants