Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action plugin support code: ensure compatibility with newer versions of ansible-core #121

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

See ansible/ansible#78860.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/plugin_utils/action_module.py

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #121 (15a757a) into main (797ad9d) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   65.83%   65.80%   -0.04%     
==========================================
  Files          10       10              
  Lines         963      962       -1     
  Branches      230      230              
==========================================
- Hits          634      633       -1     
  Misses        249      249              
  Partials       80       80              
Flag Coverage Δ
integration 64.99% <50.00%> (-0.04%) ⬇️
sanity 21.72% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/plugin_utils/action_module.py 45.31% <50.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@felixfontein
Copy link
Collaborator Author

I explicitly ran the load_vars tests against ansible/ansible#78860 (also ran them once with C.STRING_CONVERSION_ACTION mentioned in the constructor to check that it crashes), and it worked fine.

@felixfontein felixfontein merged commit b51817d into ansible-collections:main Sep 23, 2022
@felixfontein felixfontein deleted the compat branch September 23, 2022 04:45
This was referenced Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant