infra.ah_configuration.collection_repository_sync ignores check mode

[Shaps]

Summary

collection_repository_sync ignores check mode and runs sync regardless.

While not being a harmful action in itself, it's an unexpected behavior.ip a

Issue Type

• Bug Report

Ansible, Collection, Private Automation Hub details

ansible --version
ansible [core 2.17.2]
config file = /Users/andrea_tartaglia/.ansible.cfg
configured module search path = ['/Users/andrea_tartaglia/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /Users/andrea_tartaglia/.pyenv/versions/3.11.6/lib/python3.11/site-packages/ansible
ansible collection location = /Users/andrea_tartaglia/.ansible/collections:/usr/share/ansible/collections
executable location = /Users/andrea_tartaglia/.pyenv/versions/3.11.6/bin/ansible
python version = 3.11.6 (main, Nov 16 2023, 17:06:09) [Clang 15.0.0 (clang-1500.0.40.1)] (/Users/andrea_tartaglia/.pyenv/versions/3.11.6/bin/python3.11)
jinja version = 3.1.2
libyaml = True

ansible-galaxy collection list
# /Users/andrea_tartaglia/.ansible/collections/ansible_collections

Collection Version

---

ansible.controller 4.4.2  
ansible.posix 1.5.4  
community.docker 3.6.0  
community.general 8.2.0  
community.library_inventory_filtering_v1 1.0.0  
infra.ah_configuration 2.0.6

# /Users/andrea_tartaglia/.pyenv/versions/3.11.6/lib/python3.11/site-packages/ansible_collections

Collection Version

---

amazon.aws 8.1.0  
ansible.netcommon 6.1.3  
ansible.posix 1.5.4  
ansible.utils 4.1.0  
ansible.windows 2.4.0  
arista.eos 9.0.0  
awx.awx 24.6.1
azure.azcollection 2.6.0  
check_point.mgmt 5.2.3  
chocolatey.chocolatey 1.5.1  
cisco.aci 2.10.1
cisco.asa 5.0.1  
cisco.dnac 6.16.0
cisco.intersight 2.0.9  
cisco.ios 8.0.0  
cisco.iosxr 9.0.0  
cisco.ise 2.9.2  
cisco.meraki 2.18.1
cisco.mso 2.8.0  
cisco.nxos 8.1.0  
cisco.ucs 1.10.0
cloud.common 3.0.0  
cloudscale_ch.cloud 2.3.1  
community.aws 8.0.0  
community.ciscosmb 1.0.9  
community.crypto 2.21.0
community.digitalocean 1.26.0
community.dns 3.0.2  
community.docker 3.11.0
community.general 9.2.0  
community.grafana 1.9.1  
community.hashi_vault 6.2.0  
community.hrobot 2.0.1  
community.library_inventory_filtering_v1 1.0.1  
community.libvirt 1.3.0  
community.mongodb 1.7.5  
community.mysql 3.9.0  
community.network 5.0.3  
community.okd 3.0.1  
community.postgresql 3.4.1  
community.proxysql 1.6.0  
community.rabbitmq 1.3.0  
community.routeros 2.17.0
community.sap_libs 1.4.2  
community.sops 1.8.0  
community.vmware 4.5.0  
community.windows 2.2.0  
community.zabbix 2.5.1  
containers.podman 1.15.4
cyberark.conjur 1.3.0  
cyberark.pas 1.0.25
dellemc.enterprise_sonic 2.4.0  
dellemc.openmanage 9.4.0  
dellemc.powerflex 2.5.0  
dellemc.unity 2.0.0  
f5networks.f5_modules 1.29.0
fortinet.fortimanager 2.5.0  
fortinet.fortios 2.3.7  
frr.frr 2.0.2  
google.cloud 1.3.0  
grafana.grafana 5.3.0  
hetzner.hcloud 3.1.1  
ibm.qradar 3.0.0  
ibm.spectrum_virtualize 2.0.0  
ibm.storage_virtualize 2.4.1  
ieisystem.inmanage 2.0.0  
infinidat.infinibox 1.4.5  
infoblox.nios_modules 1.6.1  
inspur.ispim 2.2.3  
inspur.sm 2.3.0  
junipernetworks.junos 8.0.0  
kaytus.ksmanage 1.2.2  
kubernetes.core 3.2.0  
kubevirt.core 1.5.0  
lowlydba.sqlserver 2.3.3  
microsoft.ad 1.6.0  
netapp.cloudmanager 21.22.1
netapp.ontap 22.11.0
netapp.storagegrid 21.12.0
netapp_eseries.santricity 1.4.0  
netbox.netbox 3.19.1
ngine_io.cloudstack 2.3.0  
ngine_io.exoscale 1.1.0  
openstack.cloud 2.2.0  
openvswitch.openvswitch 2.1.1  
ovirt.ovirt 3.2.0  
purestorage.flasharray 1.30.0
purestorage.flashblade 1.17.0
sensu.sensu_go 1.14.0
splunk.es 3.0.0  
t_systems_mms.icinga_director 2.0.1  
telekom_mms.icinga_director 2.1.2  
theforeman.foreman 4.0.0  
vmware.vmware 1.3.0  
vmware.vmware_rest 3.0.1  
vultr.cloud 1.13.0
vyos.vyos 4.1.0  
wti.remote 1.0.5


Private Automation Hub version: 4.9.2

• ansible installation method: pip

OS / ENVIRONMENT

N/A I tested this on MacOS, but doubt the OS is relevant in this case

Desired Behavior

for the sync not to run when --check is passed to the playbook

Actual Behavior

The sync start regardless

STEPS TO REPRODUCE

Run the following playbook in check_mode

- hosts: localhost
  tasks:
    - name: Sync repos
      infra.ah_configuration.collection_repository_sync:
        name: community

ansible-playbook -C test.yml