Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the connection name when timing out #840

Closed
fosterseth opened this issue Sep 8, 2023 · 0 comments
Closed

Log the connection name when timing out #840

fosterseth opened this issue Sep 8, 2023 · 0 comments
Assignees
Labels
complexity:easy complexity category good first issue Good for newcomers

Comments

@fosterseth
Copy link
Member

fosterseth commented Sep 8, 2023

We should name which connection timed out here. It isn't easy from the logs to determine which connection was dropped.

timedOut[i]()

Easiest way to hit this error message is to drop traffic, e.g. if I have 2 local nodes, connected on tcp port 2222

sudo ip6tables -D INPUT -p tcp -s localhost -d localhost --dport 2222 -j DROP

same with this line

s.Logger.Debug("connInfo cancelled during flood write")

we should list the connection name

@fosterseth fosterseth changed the title Log connection name when timing out Log the connection name when timing out Sep 8, 2023
@AaronH88 AaronH88 added good first issue Good for newcomers complexity:easy complexity category and removed needs_triage labels Sep 11, 2023
@matoval matoval self-assigned this Sep 11, 2023
@matoval matoval closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy complexity category good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants