-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid changing entities ids after plotting #3421
Open
germa89
wants to merge
36
commits into
main
Choose a base branch
from
fix/changing-entities-ids-after-plotting
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+269
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 51e514f.
germa89
requested review from
clatapie and
pyansys-ci-bot
and removed request for
a team
September 20, 2024 11:15
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
This reverts commit 51e514f.
…thub.com/ansys/pymapdl into fix/changing-entities-ids-after-plotting
germa89
changed the title
fix/changing entities ids after plotting
fix: changing entities ids after plotting
Sep 20, 2024
germa89
changed the title
fix: changing entities ids after plotting
fix: avoid changing entities ids after plotting
Sep 20, 2024
github-actions
bot
added
the
documentation
Documentation related (improving, adding, etc)
label
Sep 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3421 +/- ##
==========================================
+ Coverage 85.14% 85.28% +0.14%
==========================================
Files 55 55
Lines 9962 9950 -12
==========================================
+ Hits 8482 8486 +4
+ Misses 1480 1464 -16 |
github-actions
bot
added
CI/CD
Related with CICD, Github Actions, etc
maintenance
General maintenance of the repo (libraries, cicd, etc)
labels
Sep 23, 2024
…ps://github.com/ansys/pymapdl into fix/changing-entities-ids-after-plotting
germa89
commented
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Issue, problem or error in PyMAPDL
CI/CD
Related with CICD, Github Actions, etc
documentation
Documentation related (improving, adding, etc)
examples
Publishing PyMAPDL examples
maintenance
General maintenance of the repo (libraries, cicd, etc)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid plotting changing the id of the returned elements.
Issue linked
Close #3372
Close #3374
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)