Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid changing entities ids after plotting #3421

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 20, 2024

Description

Avoid plotting changing the id of the returned elements.

Issue linked

Close #3372
Close #3374

Checklist

@germa89 germa89 requested a review from a team as a code owner September 20, 2024 11:15
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team September 20, 2024 11:15
@germa89 germa89 self-assigned this Sep 20, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Issue, problem or error in PyMAPDL label Sep 20, 2024
@germa89 germa89 changed the title fix/changing entities ids after plotting fix: changing entities ids after plotting Sep 20, 2024
@germa89 germa89 changed the title fix: changing entities ids after plotting fix: avoid changing entities ids after plotting Sep 20, 2024
@github-actions github-actions bot added the documentation Documentation related (improving, adding, etc) label Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (8298793) to head (9439401).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3421      +/-   ##
==========================================
+ Coverage   85.14%   85.28%   +0.14%     
==========================================
  Files          55       55              
  Lines        9962     9950      -12     
==========================================
+ Hits         8482     8486       +4     
+ Misses       1480     1464      -16     

@github-actions github-actions bot added the examples Publishing PyMAPDL examples label Sep 23, 2024
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) examples Publishing PyMAPDL examples maintenance General maintenance of the repo (libraries, cicd, etc)
Projects
None yet
2 participants