Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@umijs/pro-layout 文档优化 #1786

Closed
4 tasks done
afc163 opened this issue Jan 28, 2021 · 5 comments · Fixed by umijs/umi#6131
Closed
4 tasks done

@umijs/pro-layout 文档优化 #1786

afc163 opened this issue Jan 28, 2021 · 5 comments · Fixed by umijs/umi#6131
Assignees
@chenshuai2144
Labels
📝 doc

Comments

@afc163
Copy link
Member

afc163 commented Jan 28, 2021 •
edited by chenshuai2144
Loading

https://github.com/umijs/umi/blob/master/docs/plugins/plugin-layout.zh-CN.md#%E6%89%A9%E5%B1%95%E7%9A%84%E8%B7%AF%E7%94%B1%E9%85%8D%E7%BD%AE

  • 新增如下配置 的描述很奇怪，这里是文档不是 changelog。最好不要写这样的语句。

图片

  • target 属性很常用，我补充在 docs: add target blank in example code umijs/umi#6087 里了。
  • 下面的 name icon 和其他两个属性的层级不是同一级，放在一起非常奇怪。需要拉出两个层级。
  • 下面的 menu 里的 name icon 和 flatMenu/access 只有一共四个属性的说明，其他的没有，比较奇怪，建议都补全。
@chenshuai2144 chenshuai2144 self-assigned this Jan 28, 2021
@chenshuai2144
Copy link
Contributor

menu 要同时支持一下吗，这个是plugin插件支持的，我更推荐打平直接写

@chenshuai2144 chenshuai2144 mentioned this issue Feb 6, 2021
Merged
@afc163
Copy link
Member Author

afc163 commented Feb 7, 2021

menu 要同时支持一下吗，这个是plugin插件支持的，我更推荐打平直接写

啥意思？

@chenshuai2144
Copy link
Contributor

这样的方式

menu : {
 name: string
},
name:string

@afc163
Copy link
Member Author

afc163 commented Feb 10, 2021

打平比较好

@chenshuai2144
Copy link
Contributor

我删掉了非打平的用法

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenshuai2144 chenshuai2144

Labels
📝 doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update layout docs umijs/umi
2 participants
@afc163 @chenshuai2144