Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PointerManager support multi pointer event #1005

Merged
merged 15 commits into from
Oct 21, 2022
Merged

PointerManager support multi pointer event #1005

merged 15 commits into from
Oct 21, 2022

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator

  • Optimization code.
  • Support for multiple pointers.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Sep 6, 2022
@cptbtptpbcptdtptp cptbtptpbcptdtptp added enhancement New feature or request Input Input related functions labels Sep 6, 2022
@cptbtptpbcptdtptp cptbtptpbcptdtptp added this to the 0.9 milestone Sep 6, 2022
@cptbtptpbcptdtptp
Copy link
Collaborator Author

#937

@cptbtptpbcptdtptp
Copy link
Collaborator Author

image

@cptbtptpbcptdtptp
Copy link
Collaborator Author

image

@cptbtptpbcptdtptp cptbtptpbcptdtptp mentioned this pull request Sep 6, 2022
Closed
@GuoLei1990 GuoLei1990 linked an issue Oct 10, 2022 that may be closed by this pull request
optimize: [PointerManager] multi-pointer logic optimization #937
Closed
GuoLei1990
GuoLei1990 requested changes Oct 13, 2022
View reviewed changes
packages/core/src/Script.ts Show resolved Hide resolved
packages/core/src/input/InputManager.ts Outdated Show resolved Hide resolved
packages/core/src/input/pointer/Pointer.ts Outdated Show resolved Hide resolved
@GuoLei1990 GuoLei1990 changed the title refactor: PointerManager multi-pointer logic optimization PointerManager support multi-pointer Oct 21, 2022
@GuoLei1990 GuoLei1990 changed the title PointerManager support multi-pointer PointerManager support multi pointer event Oct 21, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 42.08% // Head: 44.06% // Increases project coverage by +1.97% 🎉

Coverage data is based on head (48feb36) compared to base (bb949ed).
Patch coverage: 11.29% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/0.9    #1005      +/-   ##
===========================================
+ Coverage    42.08%   44.06%   +1.97%     
===========================================
  Files          342      342              
  Lines        17950    17950              
  Branches      2495     2485      -10     
===========================================
+ Hits          7555     7909     +354     
+ Misses        9787     9387     -400     
- Partials       608      654      +46
Impacted Files Coverage Δ
packages/core/src/Script.ts 88.05% <ø> (+4.47%) ⬆️
packages/core/src/input/InputManager.ts 45.56% <0.00%> (+7.29%) ⬆️
packages/core/src/input/enums/PointerPhase.ts 100.00% <ø> (ø)
packages/core/src/input/pointer/Pointer.ts 12.00% <9.52%> (-8.00%) ⬇️
packages/core/src/input/pointer/PointerManager.ts 28.35% <10.14%> (+6.40%) ⬆️
packages/core/src/input/enums/PointerButton.ts 100.00% <100.00%> (ø)
packages/core/src/DisorderedArray.ts 55.55% <0.00%> (-7.41%) ⬇️
packages/math/src/Color.ts 64.70% <0.00%> (-1.69%) ⬇️
packages/math/src/Matrix.ts 90.53% <0.00%> (+0.27%) ⬆️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 merged commit 8da10c5 into galacean:dev/0.9 Oct 21, 2022
@GuoLei1990 GuoLei1990 added the breaking breaking change label Oct 21, 2022
gz65555 added a commit that referenced this pull request Oct 25, 2022
@gz65555
Revert "PointerManager support multi pointer event (#1005)"
d78c772 
This reverts commit 8da10c5.
@gz65555 gz65555 mentioned this pull request Oct 25, 2022
Merged
GuoLei1990 pushed a commit that referenced this pull request Oct 25, 2022
@gz65555
Revert "PointerManager support multi pointer event (#1005)" (#1127)
2306564 
This reverts commit 8da10c5.
GuoLei1990 added a commit that referenced this pull request Oct 25, 2022
@GuoLei1990
Revert "Revert "PointerManager support multi pointer event (#1005)" (…
67f2a37 
…#1127)"

This reverts commit 2306564.
GuoLei1990 added a commit that referenced this pull request Oct 25, 2022
@GuoLei1990
Revert "Revert "PointerManager support multi pointer event (#1005)" (…
b9db702 
…#1127)" (#1129)

This reverts commit 2306564.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees

@cptbtptpbcptdtptp cptbtptpbcptdtptp

Labels
breaking breaking change enhancement New feature or request Input Input related functions
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.

optimize: [PointerManager] multi-pointer logic optimization
3 participants
@cptbtptpbcptdtptp @codecov-commenter @GuoLei1990