Unable to parse Java8.g4 with javascript runtime

[onuba]

Hi all,

I am trying to parse Java files with Java8.g4 grammar from github; when I launch my jest test on NodeJS, I get the following error on the Java8Lexer.js generated file:

`SyntaxError: C:\git\stable\ncore\src\java8\antlr4\grammars\java8\Java8Lexer.js: Unexpected token, expected "," (956:70)

  954 |                     return Character.isJavaIdentifierStart(_input.LA(-1));
  955 |             case 1:
> 956 |                     return Character.isJavaIdentifierStart(Character.toCodePoint((char)_input.LA(-2), (char)_input.LA(-1)));
      |                                                                                        ^
  957 |             default:
  958 |                     throw "No predicate with index:" + predIndex;
  959 |     }

  at Parser.raise (node_modules/@babel/parser/lib/index.js:6344:17)
  at Parser.unexpected (node_modules/@babel/parser/lib/index.js:7659:16)
  at Parser.expect (node_modules/@babel/parser/lib/index.js:7645:28)
  at Parser.parseCallExpressionArguments (node_modules/@babel/parser/lib/index.js:8605:14)
  at Parser.parseSubscript (node_modules/@babel/parser/lib/index.js:8515:29)
  at Parser.parseSubscripts (node_modules/@babel/parser/lib/index.js:8434:19)
  at Parser.parseExprSubscripts (node_modules/@babel/parser/lib/index.js:8423:17)
  at Parser.parseMaybeUnary (node_modules/@babel/parser/lib/index.js:8393:21)
  at Parser.parseExprOps (node_modules/@babel/parser/lib/index.js:8280:23)
  at Parser.parseMaybeConditional (node_modules/@babel/parser/lib/index.js:8253:23)`

I generated the javascript grammar files with antlr maven plugin, using the option for it

`

<groupId>org.antlr</groupId>
<artifactId>antlr4-maven-plugin</artifactId>
<version>4.7.2</version>
<executions>
	<!-- Generate the JS parser -->
	<execution>
		<id>js</id>
		<goals>
			<goal>antlr4</goal>
		</goals>
		<configuration>
			<arguments>
				<argument>-Dlanguage=JavaScript</argument>
			</arguments>
		</configuration>
	</execution>
</executions>

`

I saw a similar issue with go and Java.g4 grammar on #1397

¿Maybe is necessary to apply the same patch to Java8.g4 that was applied to Java.g4 in this comment #1397 (comment)?

P.D: Windows 10 with NodeJS v10.15.3 and antlr4 v4.7.2, the files were generated with openJDK 11 and eclipse 2019-03

Thanks in advice!

[onuba]

OK! My mistake!!! I see a java8 grammar for javascript target at https://github.com/antlr/grammars-v4/tree/master/java8-js .

I will use it. Closing this.