Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript runtime] Bad field name, bad comments #3710

Closed
kaby76 opened this issue May 15, 2022 · 2 comments
Closed

[JavaScript runtime] Bad field name, bad comments #3710

kaby76 opened this issue May 15, 2022 · 2 comments
Labels
Milestone

Comments

@kaby76
Copy link
Contributor

kaby76 commented May 15, 2022

In this SO question, I took a look at the JavaScript runtime to see if buildParseTrees is defined for a parser. Indeed it is, but I noticed there is one applied occurrence of the field erroneously spelled _buildParseTrees. Of course, in the warped world of JS, this is not caught either by compiler or runtime.

Also, there is no "getBuildParseTree()" noted here and here.

I realize "code reviews" are old school, but relying on a terrible programming language like Javascript to find errors is not going to work.

@matthew-dean
Copy link

Ideally the runtime would / should be written in TypeScript (or at least type-checked JavaScript annotated with JSDoc types), which would catch these immediately at build time. JavaScript is only a "terrible programming language" if the tools one is using for it are terrible.

@KvanTTT
Copy link
Member

KvanTTT commented May 1, 2023

Maybe discussion about TypeScript target would be interesting for you: #3867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants