Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to illuminate/collections #13

Open
hackel opened this issue Oct 26, 2020 · 0 comments
Open

Migrate to illuminate/collections #13

hackel opened this issue Oct 26, 2020 · 0 comments

Comments

@hackel
Copy link

hackel commented Oct 26, 2020

Your README states that you depend on Tightenco\Collect, but that package has been deprecated in favour of the official upstream illuminate/collections package (which is also provided by laravel/framework). Curiously, you don't even seem to use that package in favour of your own pragmarx/ia-collection, which could also be deprecated as far as I can tell.

This would be nice to reduce the amount of duplicate code I'm pulling in a Laravel project, and certainly be easier for you to maintain without having to check for and pull in any upstream changes all the time. Mostly though it's just a pet-peeve that I've always got to search for the correct Collection/Arr/Str classes to use when I just want the official ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant