Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Link Sanitization and Electron.js Version Update #31

Open
masood opened this issue Nov 26, 2023 · 0 comments
Open

[Bug] Link Sanitization and Electron.js Version Update #31

masood opened this issue Nov 26, 2023 · 0 comments

Comments

@masood
Copy link

masood commented Nov 26, 2023

Summary:
Thank you for designing the Image Optimizer Desktop Application making it open-source and available. The application does a great job of following secure practices. We list pointers of concern below that can help make the application more secure.

[Sanitizing URLs] The app uses shell.openExternal(url) based on an IPC message [Link]. It will be helpful to sanitize URLs and especially prevent file:// links from being passed and executed on the user’s system. [Link]
[Preventing In-app Navigation] Since the app does not need to support navigation, it will be useful to prevent all attempts at in-app navigation by adding a listener on will-navigate and a handler function on setWindowOpenHandler.
[Keeping up-to-date w/ Electron.js]: The application uses an old version of Electron.js (v16.0.5) and Chromium which is vulnerable to numerous known V8 and Blink attacks. Upgrading to an even newer version will be a great idea as well [Link]

Thank you!

Platform(s) Affected:
MacOS


Mir Masood Ali, PhD student, University of Illinois at Chicago
Mohammad Ghasemisharif, PhD Candidate, University of Illinois at Chicago
Chris Kanich, Associate Professor, University of Illinois at Chicago
Jason Polakis, Associate Professor, University of Illinois at Chicago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant