Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: line options #1308

Merged
merged 4 commits into from
Jul 22, 2020
Merged

feat: line options #1308

merged 4 commits into from
Jul 22, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Jul 20, 2020 •
edited
Loading

  • shape（阶梯图是否要分开？）
  • point
  • scrollbar
  • slider
  • mark point, line, area
  • animate (pie 也加上了)
  • interaction
  • theme (pie, tiny-line 也加上了)

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 20, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 20, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@hustcc hustcc force-pushed the feat-line-options branch from c44726c to 4772209 Compare July 21, 2020 01:06
@hustcc hustcc closed this Jul 21, 2020
@hustcc hustcc force-pushed the feat-line-options branch from 4772209 to a625191 Compare July 21, 2020 01:43
@hustcc hustcc reopened this Jul 21, 2020
@hustcc hustcc force-pushed the feat-line-options branch from 3c5cb72 to 6be42eb Compare July 21, 2020 07:06
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2020

This pull request fixes 1 alert when merging 6be42eb into 23b6ac9 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc force-pushed the feat-line-options branch from 6be42eb to d33f49c Compare July 21, 2020 13:27
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2020

This pull request fixes 1 alert when merging d33f49c into 8214a0c - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc added this to the v2 milestone Jul 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jul 22, 2020

This pull request fixes 1 alert when merging 1b7688f into 8214a0c - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc merged commit 0b481d5 into v2 Jul 22, 2020
@hustcc hustcc deleted the feat-line-options branch July 22, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @visiky