Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 完善散点图功能、新增测试用例 #1322

Merged
merged 24 commits into from
Jul 23, 2020
Merged

feat: 完善散点图功能、新增测试用例 #1322

merged 24 commits into from
Jul 23, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Jul 22, 2020

No description provided.

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 22, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 22, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

visiky
visiky reviewed Jul 22, 2020
View reviewed changes
__tests__/unit/plots/scatter/shape-spec.ts Outdated Show resolved Hide resolved
__tests__/unit/plots/scatter/shape-spec.ts Show resolved Hide resolved
__tests__/unit/plots/scatter/size-spec.ts Outdated Show resolved Hide resolved
__tests__/unit/plots/scatter/style-spec.ts Outdated Show resolved Hide resolved
__tests__/unit/plots/scatter/style-spec.ts Outdated Show resolved Hide resolved
src/plots/scatter/types.ts Outdated Show resolved Hide resolved
lessmost
lessmost reviewed Jul 23, 2020
View reviewed changes
src/constants/index.ts Outdated Show resolved Hide resolved
@lxfu1 lxfu1 merged commit 8da53b8 into v2 Jul 23, 2020
@lxfu1 lxfu1 deleted the feat/scatter branch July 23, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky left review comments

@hustcc hustcc hustcc left review comments

@lessmost lessmost lessmost left review comments

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

Assignees

@hustcc hustcc

Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lxfu1 @lessmost @hustcc @visiky