Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v2/column): support grouped and stacked column #1333

Merged
merged 1 commit into from
Jul 26, 2020
Merged

feat(v2/column): support grouped and stacked column #1333

merged 1 commit into from
Jul 26, 2020

Conversation

lessmost
Copy link
Member

No description provided.

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 24, 2020
tests-checker[bot]
tests-checker bot suggested changes Jul 24, 2020
View reviewed changes
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@lessmost lessmost requested review from hustcc, BBSQQ, lxfu1 and visiky July 24, 2020 09:25
hustcc
hustcc reviewed Jul 26, 2020
View reviewed changes
__tests__/unit/plots/column/index-spec.ts
xField: 'area',
yField: 'sales',
colorField: 'series',
isStack: true,
Copy link
Member

@hustcc hustcc Jul 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit 默认是 group，可以设置为 stack 是吧？

hustcc
hustcc reviewed Jul 26, 2020
View reviewed changes
src/plots/column/types.ts
/** 柱子宽度占比 [0-1] */
readonly marginRatio?: number;
/** 分组或堆叠内部的间距，像素值 */
readonly innerPadding?: number;
Copy link
Member

@hustcc hustcc Jul 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 这两个是 v1 已经有的能力吗？

@hustcc
Copy link
Member

hustcc commented Jul 26, 2020

代码没有问题，两个疑问：

  1. 默认是 group，可以设置为 stack 是吧？
  2. marginRatio，innerPadding 是 v1 已经有的配置和能力吗？

@hustcc hustcc merged commit 758b4e3 into v2 Jul 26, 2020
@hustcc hustcc deleted the feat-column-grouped-stacked branch July 26, 2020 12:47
@lessmost
Copy link
Member Author

  1. 默认是 group，设置 isStack 即为堆叠了
  2. marginRation 在 v1 中是可以配置的，innerPadding 没有，这次准备加上

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tests-checker tests-checker[bot] tests-checker[bot] requested changes

@hustcc hustcc hustcc approved these changes

@BBSQQ BBSQQ Awaiting requested review from BBSQQ

@lxfu1 lxfu1 Awaiting requested review from lxfu1

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lessmost @hustcc