feat(area): add plot area #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hustcc
commented
Jul 30, 2020
hustcc
commented
- 面积图
- adaptor 一些是复用 line，一些的自己写。
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
visiky
reviewed
Jul 30, 2020
lessmost
reviewed
Jul 30, 2020
| chart.data(data); | ||
| const geometry = chart.area().position(`${xField}*${yField}`); | ||
|
|
||
| if (seriesField) { |
There was a problem hiding this comment.
这个 seriesField 在其他图形中叫法可能不一致，有 colorField/stackField,
我倾向 colorField，或者同时支持 colorField/stackField/seriesField，几个配置同时支持🌚
There was a problem hiding this comment.
这个要在发布版本之前确定一个标准了，或者我去问下米法，当初的命名规范是什么？
lessmost
reviewed
Jul 30, 2020
lessmost
reviewed
Jul 30, 2020
lessmost
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.