Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 添加 website #1368

Merged
merged 7 commits into from
Jul 31, 2020
Merged

feat: 添加 website #1368

merged 7 commits into from
Jul 31, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Jul 30, 2020

  • 基于 @antv/gatsby-theme-antv 初始化 website 。

@auto-add-label auto-add-label bot added the enhancement New feature or request label Jul 30, 2020
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

docs/manual/introduction.en.md Outdated Show resolved Hide resolved
docs/manual/introduction.zh.md Outdated Show resolved Hide resolved
docs/manual/introduction.en.md Outdated Show resolved Hide resolved
docs/manual/introduction.zh.md Outdated Show resolved Hide resolved
@hustcc
Copy link
Member

hustcc commented Jul 30, 2020

  1. 图形的 example 都暂时去掉吧。
  2. 然后单独一个 pr,增加 scatter 的 example,后面其他的 example 的 pr 都参考这个一个 pr 去写!

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

docs/manual/graphic-style.en.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.zh.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.en.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.zh.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.en.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.zh.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.en.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.zh.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.en.md Outdated Show resolved Hide resolved
docs/manual/graphic-style.zh.md Outdated Show resolved Hide resolved
@lxfu1
Copy link
Member Author

lxfu1 commented Jul 31, 2020

  1. 图形的 example 都暂时去掉吧。
  2. 然后单独一个 pr,增加 scatter 的 example,后面其他的 example 的 pr 都参考这个一个 pr 去写!

example 我补充了文档, 感觉不用单独的 PR , 可以看看 examples/scatter/basic 。

.eslintrc Show resolved Hide resolved
@hustcc hustcc self-requested a review July 31, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants