Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 迷你图走查 + demo #1528

Merged
merged 7 commits into from
Sep 5, 2020
Merged

chore: 迷你图走查 + demo #1528

merged 7 commits into from
Sep 5, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 5, 2020

  • line
  • area
  • column
  • progress
  • ring-progress

@hustcc
Copy link
Member Author

hustcc commented Sep 5, 2020

终于搞完了。主要的重构点&改动

  1. 增加 demo
  2. 对柱条类的图,增加 widthRatio 已经单测
  3. color 字段的使用,和其他图保持一致
  4. 提升 adaptor 的复用(比如 ring-progress 和 progress 的区别仅仅在于 coordinate)

@hustcc hustcc requested a review from visiky September 5, 2020 09:02
@hustcc hustcc force-pushed the chore-walkthrough-mini-plots branch from 3ded3a3 to d604fd2 Compare September 5, 2020 09:05
@hustcc hustcc requested a review from lxfu1 September 5, 2020 09:07
@hustcc hustcc merged commit d022fd4 into master Sep 5, 2020
@hustcc hustcc deleted the chore-walkthrough-mini-plots branch September 5, 2020 10:37
/** 具体的数据 */
readonly data: number[];
/** 是否平滑 */
readonly smooth?: boolean;
/** 是否连接空数据 */
readonly connectNulls?: boolean;
/** 折线extra图形样式 */
readonly lineStyle?: ShapeStyle | ((x?: number, y?: number) => ShapeStyle);
readonly lineStyle?: ShapeStyle | (() => ShapeStyle);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要参数吗?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要,对于折线图、面积图,这个参数,其实对于图形没有太大意义,因为一条线是一个 elememt。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants