fix(line): fix error when color field is cat #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzhenying
reviewed
Sep 24, 2020
| @@ -108,7 +108,8 @@ export function geometry<O extends GeometryOptions>(params: Params<O>): Params<O | |||
| if (isString(color)) { | |||
| colorField ? geometry.color(colorField, color) : geometry.color(color); | |||
| } else if (isFunction(color)) { | |||
| const mappingFields = getMappingField(options, 'color'); | |||
| // 对于单折线图的特殊处理，如果 x 轴是分类 scale，会导致映射错误 | |||
| const mappingFields = getMappingField(options, 'color').filter((f: string) => f !== xField); | |||
| geometry.color(mappingFields.join('*'), getMappingFunction(mappingFields, color)); | |||
There was a problem hiding this comment.
这块儿感觉会留下隐患，即 geo.color(size/shape)，若触发了 mappingField 里含有 cat 类字段，会在视觉通道映射出来，而不是只作为参数传入。不过我过了遍我们现在的图表，除了这次修的多折线图，暂时没发现其他触发这一 问题的 case，所以先过了~
There was a problem hiding this comment.
是的，因为目前只有 line 会出现问题，而 line 目前只有 x y colorField，如果后面有 shapeField，可能就崩了。但是目前 shapeField 只有 scatter 会用到，scatter 的 point 又不会有 line 的问题。
liuzhenying
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.