Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 旭日图类型定义和实现 #1630

Merged
merged 3 commits into from
Sep 24, 2020
Merged

feat: 旭日图类型定义和实现 #1630

merged 3 commits into from
Sep 24, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Sep 24, 2020

image

@auto-add-label auto-add-label bot added the enhancement New feature or request label Sep 24, 2020
@hustcc
Copy link
Member

hustcc commented Sep 24, 2020

这个旭日图看起来挺好看的~

hustcc
hustcc reviewed Sep 24, 2020
View reviewed changes
src/index.ts Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Sep 24, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/adaptor/geometries/polygon.ts
@@ -0,0 +1,31 @@
import { deepMix } from '@antv/util';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个文件也要加单层，底层代码100覆盖，可以下一个分支处理。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

src/index.ts Outdated Show resolved Hide resolved
src/plots/sunburst/adaptor.ts Show resolved Hide resolved
hustcc
hustcc reviewed Sep 24, 2020
View reviewed changes
src/plots/sunburst/utils.ts
* sunburst 处理数据
* @param options
*/
export function transformData(options: SunburstOptions) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Util方法 100% 覆盖，可下个分支处理

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

hustcc
hustcc reviewed Sep 24, 2020
View reviewed changes
src/plots/sunburst/types.ts
@@ -0,0 +1,20 @@
import { Options, StyleAttr } from '../../types';

export interface SunburstOptions extends Omit<Options, 'data' | 'legend' | 'slider' | 'scrollbar' | 'xAxis' | 'yAxis'> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xField yField 也去掉，不然会提示，下个分支改。

src/plots/sunburst/adaptor.ts
const coord = chart.coordinate({
type: 'polar',
cfg: {
innerRadius,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Radius没用上。

@hustcc hustcc merged commit 24b3515 into master Sep 24, 2020
@hustcc hustcc deleted the feat/sun-brust branch September 24, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcsin1 arcsin1 arcsin1 left review comments

@hustcc hustcc hustcc left review comments

Assignees
No one assigned
Labels
enhancement New feature or request PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxfu1 @hustcc @arcsin1