feat(line): line area support isStack options #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hustcc
commented
Oct 12, 2020
•
hustcc
commented
- 折线图支持 isStack
- 面积图支持 isStack
- 双轴图 line 支持 isStack
- 双轴图 legend: false 出现的 异常
- 修复 lint 的 warning
|
🎊 PR Preview 7d80cc2 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1705.surge.sh 🕐 Build time: 546.492s
🤖 By surge-preview |
|
isStack Line 长什么样？ |
就是数值上是高度叠加的，可以参考面积图，去掉填充颜色的意思。
双轴图中生效：
|
|
This pull request fixes 2 alerts when merging 0e618a9 into 9156861 - view on LGTM.com fixed alerts:
|
lxfu1
reviewed
Oct 13, 2020
lxfu1
approved these changes
Oct 13, 2020
visiky
reviewed
Oct 13, 2020
| @@ -41,6 +41,13 @@ export function drawSingleGeometry<O extends { xField: string; yField: string; g | |||
| }, | |||
| }) | |||
| ); | |||
|
|
|||
| // 处理 isStack | |||
| if (isStack) { | |||
There was a problem hiding this comment.
是不是直接调 adjust adaptor就好（突然在想双轴图的柱子有没有分组）
There was a problem hiding this comment.
现在是 adaptor/geometry 中的 interval 有处理 adjust，但是 line 没有处理 adjust。这个点是需要重构掉的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.