Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(point-shape): 修复 point 的 shape 映射 #1771

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Oct 23, 2020

1⃣️ point geometry 通道需要指定 shapeField,不直接使用 seriesField
2⃣️ line plot 默认将 seriesField 作为 shapeField,作为 shape 回调参数使用,但是默认 shape 为 circle

point geometry 通道需要指定 shapeField,不直接使用 seriesField
line plot 默认将 seriesField 作为 shapeField,作为 shape 回调参数使用,但是默认 shape 为 circle
@visiky visiky requested a review from hustcc October 23, 2020 06:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2020

🎊 PR Preview 8d4b729 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1771.surge.sh

🕐 Build time: 660.215s

🤖 By surge-preview

@hustcc hustcc merged commit 8d4b729 into master Oct 23, 2020
@hustcc hustcc deleted the fix/point-shape-mapping branch October 23, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants