Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 基于 annotation shape 实现 regression line #1803

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Oct 27, 2020

  • api
  • demos
  • test

image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2020

😭 Deploy PR Preview 7dbc224 failed. Build logs

🤖 By surge-preview

src/plots/scatter/annotations/util.ts Outdated Show resolved Hide resolved
src/plots/scatter/annotations/util.ts Outdated Show resolved Hide resolved
src/plots/scatter/types.ts Show resolved Hide resolved
src/plots/scatter/types.ts Outdated Show resolved Hide resolved
@lxfu1 lxfu1 changed the title feat: 基于 annotation shape 实现 trendline feat: 基于 annotation shape 实现 regression line Oct 28, 2020
@hustcc hustcc self-requested a review October 28, 2020 06:07
@hustcc
Copy link
Member

hustcc commented Oct 28, 2020

合并了,后面补充一些单测。一些 util 的单测可以直接从 G2 copy 过来,如果 G2 也没有,需要自己手写补全了。

@hustcc hustcc merged commit 7dbc224 into master Oct 28, 2020
@hustcc hustcc deleted the feat/trendline branch October 28, 2020 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants