Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#1870): when y are same in dual-axes, axis position is wrong #1878

Merged
merged 4 commits into from
Nov 9, 2020
Merged

fix(#1870): when y are same in dual-axes, axis position is wrong #1878

merged 4 commits into from
Nov 9, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Nov 7, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2020 •
edited
Loading

🎊 PR Preview 4e7e022 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1878.surge.sh

🕐 Build time: 646.591s

🤖 By surge-preview

@hustcc hustcc requested review from liuzhenying and arcsin1 November 7, 2020 13:58
@hustcc
Copy link
Member Author

hustcc commented Nov 7, 2020

目前只能修复，在没有设置任何 yAxis 的时候，并且 y field 相同情况下， yAxis 显示问题，如果要完全解决，可能最终的方式还是数组存储，不过兼容 object 的方式而已。

@coveralls
Copy link

coveralls commented Nov 7, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 353094762

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 94.837%
Totals Coverage Status
Change from base Build 350985684: 0.01%
Covered Lines: 3710
Relevant Lines: 3797
💛 - Coveralls

@hustcc hustcc requested a review from visiky November 7, 2020 14:14
@lessmost lessmost merged commit 4e7e022 into master Nov 9, 2020
@lessmost lessmost deleted the fix-1870 branch November 9, 2020 07:07
jinhuiWong pushed a commit to jinhuiWong/G2Plot that referenced this pull request Nov 15, 2020
@hustcc
fix(antvis#1870): when y are same in dual-axes, axis position is wrong (
15f442e 
antvis#1878)

* fix(antvis#1870): when y are same in dual-axes, axis position is wrong

* chore: update type define

* test: inc coverage

* fix: cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcsin1 arcsin1 arcsin1 left review comments

@lessmost lessmost lessmost approved these changes

@liuzhenying liuzhenying Awaiting requested review from liuzhenying

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.0.7版本双轴图 yField 相同时 左yAxis 不显示
4 participants
@hustcc @coveralls @lessmost @arcsin1