Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新增堆叠分组功能 #1893

Merged
merged 7 commits into from
Nov 10, 2020
Merged

feat: 新增堆叠分组功能 #1893

merged 7 commits into from
Nov 10, 2020

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Nov 10, 2020

fixed #1883

  • Bar | Column | DualAxes 新增堆叠分组功能

  • 修改 DualAxes 无数据时 legend 不展示

  • test

  • api

  • demos

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2020

🎊 PR Preview fdd9fcf has been successfully built and deployed to https://antvis-G2Plot-preview-pr-1893.surge.sh

🕐 Build time: 511.178s

🤖 By surge-preview

@hustcc
Copy link
Member

hustcc commented Nov 10, 2020

@zqLu @me-momo @liuzhenying 这个能力的配置项,大家可以看看。

@coveralls
Copy link

coveralls commented Nov 10, 2020

Pull Request Test Coverage Report for Build 355892642

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 96.048%

Totals Coverage Status
Change from base Build 355507193: -0.003%
Covered Lines: 3721
Relevant Lines: 3774

💛 - Coveralls

@lessmost
Copy link
Member

@zqLu @me-momo @liuzhenying 这个能力的配置项,大家可以看看。

是不是可以考虑下面两种方案:

  1. groupField + stackField
  2. seriesField string[] 形式?

@lxfu1
Copy link
Member Author

lxfu1 commented Nov 10, 2020

@zqLu @me-momo @liuzhenying 这个能力的配置项,大家可以看看。

是不是可以考虑下面两种方案:

  1. groupField + stackField
  2. seriesField string[] 形式?

目前用的方案1,groupField 指定的时候优先级高于seriesField,stackField 用的 xField。

@hustcc
Copy link
Member

hustcc commented Nov 10, 2020

剩余问题: 堆积分组柱中的 hover 背景错位。

@hustcc hustcc self-requested a review November 10, 2020 13:14
@hustcc hustcc merged commit fdd9fcf into master Nov 10, 2020
@hustcc hustcc deleted the feat/di-chart branch November 10, 2020 13:15
jinhuiWong pushed a commit to jinhuiWong/G2Plot that referenced this pull request Nov 15, 2020
* feat: 新增堆叠分组功能

* feat: 补充双轴图堆叠分组 line

* fix: tests

* fix: conversation

* fix: 修复 tooltip 偏移

* docs: 打开tooltip

* fix: word

Co-authored-by: liufu.lf <liufu.lf@antfin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

分组层叠柱状图
4 participants