Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new plot sankey 桑基图 #2016

Merged
merged 8 commits into from
Dec 2, 2020
Merged

feat: new plot sankey 桑基图 #2016

merged 8 commits into from
Dec 2, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Nov 26, 2020

  • layout
  • adaptor
  • tests
  • example
  • docs

image

image

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2020

😭 Deploy PR Preview 8423f1a failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Nov 26, 2020

Pull Request Test Coverage Report for Build 395644599

  • 121 of 121 (100.0%) changed or added relevant lines in 9 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 96.677%

Files with Coverage Reduction New Missed Lines %
src/adaptor/geometries/base.ts 1 98.52%
src/adaptor/conversion-tag.ts 2 92.54%
src/plots/scatter/adaptor.ts 3 91.53%
Totals Coverage Status
Change from base Build 382637271: -0.04%
Covered Lines: 4125
Relevant Lines: 4162

💛 - Coveralls

@hustcc hustcc changed the title feat: new plot sankey feat: new plot sankey 桑基图 Nov 26, 2020
@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 3 alerts when merging fe7aaa1 into cdc99d1 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 3 alerts when merging 25c6e97 into cdc99d1 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 1 alert when merging 51316a8 into cdc99d1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2020

This pull request introduces 1 alert when merging 82e6b22 into 59d636a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2020

This pull request introduces 1 alert when merging 68fc461 into 59d636a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Dec 2, 2020

This pull request introduces 1 alert when merging 9324328 into 59d636a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@hustcc
Copy link
Member Author

hustcc commented Dec 2, 2020

@me-momo 要来看看 types 定义吗,把把关~

@hustcc hustcc merged commit cc2edaf into master Dec 2, 2020
@hustcc hustcc deleted the feat-sankey-plot branch December 2, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants