Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add chart type source in container #2108

Merged
merged 2 commits into from
Dec 17, 2020
Merged

feat: add chart type source in container #2108

merged 2 commits into from
Dec 17, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Dec 16, 2020

PR includes

  • 增加一个 attribute 属性，标识图表来源，便于区分是 G2 还是 G2Plot
  • add test cases

Screenshot

Before After
❌ ✅

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2020 •
edited
Loading

😭 Deploy PR Preview 2454c97 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Dec 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 424911848

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 96.715%
Totals Coverage Status
Change from base Build 424664140: 0.002%
Covered Lines: 4175
Relevant Lines: 4212
💛 - Coveralls

@hustcc hustcc requested review from lessmost and visiky December 16, 2020 05:29
@hustcc hustcc merged commit c26eb37 into master Dec 17, 2020
@hustcc hustcc deleted the chore-add-source-type-from branch December 17, 2020 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

@lessmost lessmost Awaiting requested review from lessmost

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hustcc @coveralls @lessmost @visiky