Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2116): percent transform should keep data order #2118

Merged
merged 1 commit into from
Dec 18, 2020
Merged

fix(#2116): percent transform should keep data order #2118

merged 1 commit into from
Dec 18, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Dec 18, 2020

PR includes

Screenshot

Before After
image image

  1. 传入的数据中 09 是第一个，结果绘制出来 09 变成了倒数第二，原因是使用 obejct 存储导致顺序无须。

  2. 额外修复了处理非数字的百分比计算。

@hustcc hustcc requested a review from lxfu1 December 18, 2020 01:59
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2020 •
edited
Loading

😭 Deploy PR Preview bab02e6 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 429488567

  • 14 of 14 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 96.706%
Totals Coverage Status
Change from base Build 427774579: 0.009%
Covered Lines: 4182
Relevant Lines: 4220
💛 - Coveralls

@hustcc hustcc merged commit bbda837 into master Dec 18, 2020
@hustcc hustcc deleted the fix-2116 branch December 18, 2020 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxfu1 lxfu1 lxfu1 approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

百分比堆积图 x 轴顺序和数据顺序不一致
3 participants
@hustcc @coveralls @lxfu1