Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-2161): 修复数据项存在非法 undefined 时，获取数据 max 为 NaN，导致玉珏图渲染页面崩溃 #2168

Merged
merged 1 commit into from
Jan 4, 2021
Merged

fix(issue-2161): 修复数据项存在非法 undefined 时，获取数据 max 为 NaN，导致玉珏图渲染页面崩溃 #2168

merged 1 commit into from
Jan 4, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 2, 2021 •
edited
Loading

PR includes

Screenshot

Before After
image image

@visiky visiky requested a review from hustcc January 2, 2021 22:15
@visiky visiky linked an issue Jan 2, 2021 that may be closed by this pull request
[玉珏图] 当某一数据项 value 为 undefined 时，页面崩溃 #2161
Closed
@visiky visiky requested review from liuzhenying and yujs January 2, 2021 22:18
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2021 •
edited
Loading

😭 Deploy PR Preview 640be7c failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 458272952

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.789%
Totals Coverage Status
Change from base Build 457014187: 0.0%
Covered Lines: 4465
Relevant Lines: 4503
💛 - Coveralls

@hustcc hustcc self-requested a review January 4, 2021 02:12
@visiky visiky merged commit 536adf9 into master Jan 4, 2021
@visiky visiky deleted the issue-2161 branch January 4, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@liuzhenying liuzhenying Awaiting requested review from liuzhenying

@yujs yujs Awaiting requested review from yujs

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[玉珏图] 当某一数据项 value 为 undefined 时，页面崩溃
3 participants
@visiky @coveralls @hustcc