Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 #2190

Merged
merged 6 commits into from
Jan 8, 2021
Merged

feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 #2190

merged 6 commits into from
Jan 8, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 8, 2021 •
edited
Loading

PR includes

  • add / modify test cases
  • documents, demos

PR details

  • feat(column): column 新增配置项 columnBackground
  • feat(bar): bar 新增配置项 barBackground
  • feat(radial-bar): radial-bar 新增配置项 barBackground、minBarWidth、maxBarWidth
  • docs(radial-bar): 优化玉珏图 demos (前往)
  • docs: 柱形图、条形图、玉珏图关于图形样式 文档更新，支持 minWidth、maxWidth、background

Screenshot

Before After
image image
❌ image
❌ image

visiky added 3 commits January 7, 2021 19:25
@visiky
feat(interval): interval 支持几何图形 background 设置，作用于 column、bar、radial-bar
7d215d5 
1、column 新增配置项 columnBackground
2、bar 新增配置项 barBackground
3、radial-bar 新增配置项 barBackground、minBarWidth、maxBarWidth
@visiky
docs(radial-bar): 默认关闭玉珏图动画，优化玉珏图 demo
5637c3f
@visiky
docs: 增加柱、条形图的文档 api
69ff639 
- [x] 抽取 bar-style、column-style 文档（含 minwidth、maxwidth、background 配置）
- [x] 柱形图、条形图、玉珏图 关于图形样式 文档更新，支持 minwidth、maxwidth、background
@visiky visiky requested a review from hustcc January 8, 2021 05:17
@visiky visiky requested a review from liuzhenying January 8, 2021 05:17
@visiky visiky changed the title interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图' interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 Jan 8, 2021
@visiky visiky changed the title interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 Jan 8, 2021
accesslint[bot]
accesslint bot suggested changes Jan 8, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

examples/more-plots/radial-bar/demo/background.ts Show resolved Hide resolved
examples/more-plots/radial-bar/demo/apple-watch-activity.ts Show resolved Hide resolved
@visiky visiky changed the title feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 wip: feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 Jan 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021 •
edited
Loading

😭 Deploy PR Preview 63ec5d1 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jan 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 470963975

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.84%
Totals Coverage Status
Change from base Build 468672596: 0.0%
Covered Lines: 4521
Relevant Lines: 4559
💛 - Coveralls

@visiky visiky changed the title wip: feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 feat: interval geometry 支持配置图形背景，支持图表: 柱、条形图，玉珏图 Jan 8, 2021
accesslint[bot]
accesslint bot approved these changes Jan 8, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Jan 8, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@hustcc hustcc merged commit cbd087a into master Jan 8, 2021
@hustcc hustcc deleted the interval-background branch January 8, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] approved these changes

@hustcc hustcc hustcc approved these changes

@liuzhenying liuzhenying Awaiting requested review from liuzhenying

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc