Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 词云图重写changeData方法 && 添加单测 #2214

Merged
merged 1 commit into from
Jan 13, 2021
Merged

feat: 词云图重写changeData方法 && 添加单测 #2214

merged 1 commit into from
Jan 13, 2021

Conversation

yp0413150120
Copy link
Contributor

PR includes

override the changeData method of wordCloud plot

  • add / modify test cases

Screenshot

Before After
词云图before 词云图after

@visiky visiky self-requested a review January 13, 2021 08:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 482265725

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 96.906%
Files with Coverage Reduction New Missed Lines %
src/plots/word-cloud/index.ts 1 94.12%
Totals Coverage Status
Change from base Build 482051035: 0.001%
Covered Lines: 4576
Relevant Lines: 4613
💛 - Coveralls

@visiky visiky merged commit f3d6d7e into antvis:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yp0413150120 @coveralls @visiky