Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 对称条形图 meta 支持 yField 设置别名 #2240

Merged
merged 4 commits into from
Jan 19, 2021
Merged

fix: 对称条形图 meta 支持 yField 设置别名 #2240

merged 4 commits into from
Jan 19, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Jan 19, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

  meta: {
    '2016年耕地总面积': { alias: '耕地总面积' },
    '2016年转基因种植面积': { alias: '转基因种植面积' },
  },
Before After
image image

visiky added 3 commits January 19, 2021 15:25
@visiky
feat(bidirectional-bar): 对称条形图支持 meta 配置
0911356 
由于内部进行了 series 分类以及数据转换，因此需将 yField 的别名通过 formatter 注入
@visiky
test: 添加对称条形图meta设置的单测
befd4e1
@visiky
docs: 一波文档修改
ee47beb
@visiky visiky requested review from arcsin1 and hustcc January 19, 2021 08:45
@visiky visiky changed the title feat: 对称条形图 meta 支持 yField 设置别名 fix: 对称条形图 meta 支持 yField 设置别名 Jan 19, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2021 •
edited
Loading

😭 Deploy PR Preview 1ded71c failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 495666201

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 96.848%
Totals Coverage Status
Change from base Build 494949853: -0.04%
Covered Lines: 4599
Relevant Lines: 4636
💛 - Coveralls

@hustcc hustcc merged commit 903a393 into master Jan 19, 2021
@hustcc hustcc deleted the feat-bidirectional-bar branch January 19, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@arcsin1 arcsin1 Awaiting requested review from arcsin1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc