Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 雷达图新增 innerRadius、startAngle、endAngle #2323

Merged
merged 4 commits into from
Feb 10, 2021
Merged

feat: 雷达图新增 innerRadius、startAngle、endAngle #2323

merged 4 commits into from
Feb 10, 2021

Conversation

ntscshen
Copy link
Contributor

@ntscshen ntscshen commented Feb 9, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

雷达图新增 innerRadius、startAngle、endAngle

@visiky visiky self-requested a review February 9, 2021 12:25
visiky
visiky reviewed Feb 9, 2021
View reviewed changes
docs/api/plots/radar.en.md Outdated Show resolved Hide resolved
docs/api/plots/radar.zh.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 553740098

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.618%
Totals Coverage Status
Change from base Build 548158634: 0.0%
Covered Lines: 4921
Relevant Lines: 4974
💛 - Coveralls

visiky
visiky reviewed Feb 9, 2021
View reviewed changes
__tests__/unit/plots/radar/coordinate-spec.ts Outdated
radar.render();

const coordinate = radar.chart.getCoordinate();
const { radius, startAngle, endAngle } = coordinate;
Copy link
Member

@visiky visiky Feb 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint 修复下（radius 未使用）

@hustcc hustcc merged commit 1163917 into antvis:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ntscshen @coveralls @hustcc @visiky