Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 完善图例文档 & 增加图表组件的示例导航 & 补充图例两个demo #2477

Merged
merged 4 commits into from
Mar 31, 2021
Merged

docs: 完善图例文档 & 增加图表组件的示例导航 & 补充图例两个demo #2477

merged 4 commits into from
Mar 31, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Mar 31, 2021 •
edited
Loading

PR includes

  • documents, demos
  1. 图表示例 - 新增图表组件：图例 + 图表标注
  2. API - 图表组件 - 图例，api 文档完善（⚠️ 图表组件文档模板，见这里）
  3. 新增图例的两个使用 demo
  4. 增加坐标轴构成元素介绍

Screenshot

About Preview
分类图例构成元素介绍 image
图例 position 配置
图例 itemValue 配置
坐标轴构成元素介绍 image

@visiky visiky requested review from hustcc and lxfu1 March 31, 2021 05:51
accesslint[bot]
accesslint bot suggested changes Mar 31, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

docs/api/components/legend.en.md Outdated Show resolved Hide resolved
docs/api/components/legend.zh.md Outdated Show resolved Hide resolved
accesslint[bot]
accesslint bot approved these changes Mar 31, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Mar 31, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Mar 31, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Mar 31, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

visiky
visiky commented Mar 31, 2021
View reviewed changes
Copy link
Member Author

@visiky visiky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先合并了

@visiky visiky merged commit 0740b37 into master Mar 31, 2021
@visiky visiky deleted the docs-legend branch March 31, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] approved these changes

@hustcc hustcc Awaiting requested review from hustcc

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@visiky