Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-2486): 不直接引用 @antv/matrix-util, 使用 G2 的 Util #2499

Merged
merged 1 commit into from
Apr 12, 2021
Merged

fix(issue-2486): 不直接引用 @antv/matrix-util, 使用 G2 的 Util #2499

merged 1 commit into from
Apr 12, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Apr 10, 2021 •
edited
Loading

PR includes

Screenshot

Before After
❌ ✅

@visiky visiky requested review from hustcc, liuzhenying and lxfu1 April 10, 2021 13:08
@visiky
Copy link
Member Author

visiky commented Apr 10, 2021 •
edited
Loading

@liuzhenying @lxfu1 以后不要直接使用 matrix-util，如果实在需要 package.json 指定版本（或者把 matrix-util 发一个正式版）

@liuzhenying
Copy link
Member

@liuzhenying @lxfu1 以后不要直接使用 matrix-util，如果实在需要 package.json 指定版本（或者把 matrix-util 发一个正式版）

ok

@hustcc hustcc merged commit 84fd908 into master Apr 12, 2021
@hustcc hustcc deleted the fix-2486 branch April 12, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzhenying liuzhenying liuzhenying approved these changes

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2.3.17版本treemap-drill-down-action.js中 import { ext } from '@antv/matrix-util'; 编译报错
3 participants
@visiky @liuzhenying @hustcc