Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:修复 玉珏图没有考虑isStack的情况 重新计算最大值 #2685

Merged
merged 5 commits into from
Jul 8, 2021
Merged

fix:修复 玉珏图没有考虑isStack的情况 重新计算最大值 #2685

merged 5 commits into from
Jul 8, 2021

Conversation

ai-qing-hai
Copy link
Contributor

PR includes

  • 玉珏图isStack的情况 重新修改获取最大值方法

image

@coveralls
Copy link

coveralls commented Jul 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1011280671

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 95.744%
Totals Coverage Status
Change from base Build 1007251847: -0.03%
Covered Lines: 6243
Relevant Lines: 6353
💛 - Coveralls

@visiky
Copy link
Member

visiky commented Jul 8, 2021

可以在 radial-bar 的 单测中，加一个 isStack 的情况

@ai-qing-hai
Copy link
Contributor Author

可以在 radial-bar 的 单测中，加一个 isStack 的情况

我再 getScalesMax 方法的单测后面加了 getScalesIsStackMax方法的单测。 应该是可以的

@visiky
Copy link
Member

visiky commented Jul 8, 2021

可以在 radial-bar 的 单测中，加一个 isStack 的情况

我再 getScalesMax 方法的单测后面加了 getScalesIsStackMax方法的单测。 应该是可以的

写单测的原则，就是保证 issue 中可以复现的问题，解决了不再复现了。避免其他人改动 影响

  1. 单测覆盖率不够
  2. 我先合并了，然后我来补充一个，你看下

@visiky visiky merged commit 397d864 into antvis:master Jul 8, 2021
@visiky visiky mentioned this pull request Jul 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ai-qing-hai @coveralls @visiky