refactor: 优化下玉珏图处理 stack 的代码 #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 11a45bb has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2687.surge.sh?type=diff&date=2021-07-09 🕐 Build time: 78.281s
🤖 By surge-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
ref: #2685
原则: 最小化改动。既然是计算 yScale 最大值有问题，且问题出现在于处理 stack 的时候，没有根据 stack 后的数据进行计算。那就有两个方案：
1、G2 提供钩子获取 stack 处理后的数据
2、G2Plot 自己去获取 stack 后的数据（目前选择 方案2。但是比较简单滴进行处理而已，通过独立的 util 方法，具备内聚性，后续迭代优化逻辑更可控）
Screenshot