Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(funnel): 不将 label 的 layout 的 type 设置为 interval-adjust-position #2817

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

pearmini
Copy link
Member

@pearmini pearmini commented Aug 24, 2021

之前为了解决漏斗最下面一层文字无法对其的问题,将 label 的 layout type 设置为了 interval-adjust-position。但这样会出现 label:{position: 'right'} 失效的问题,所以在 G2 层修复了文字对齐的问题,不需要设置为 interval-adjust-position 了。

G2 的解决如下:antvis/G2#3585

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2021

🎊 PR Preview b8d08d5 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2817.surge.sh?type=diff&date=2021-08-24

🕐 Build time: 75.2s

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1161109567

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 95.605%

Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 1160905716: -0.02%
Covered Lines: 6491
Relevant Lines: 6611

💛 - Coveralls

@visiky visiky merged commit de2efd5 into master Aug 24, 2021
@visiky visiky deleted the fix/funnel branch August 24, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants