Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(column): 柱状图支持 shape #2934

Merged
merged 3 commits into from
Oct 21, 2021
Merged

feat(column): 柱状图支持 shape #2934

merged 3 commits into from
Oct 21, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Oct 21, 2021

  • feat(column): 柱状图支持 shape 配置
  • feat(column): 柱状图支持 shape 添加单测和 api 文档说明

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After

@visiky visiky requested a review from hustcc October 21, 2021 07:45
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2021

🎊 PR Preview cb2479e has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2934.surge.sh?type=diff&date=2021-10-21

🕐 Build time: 137.261s

🤖 By surge-preview

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1366932181

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 95.347%

Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 1366168430: -0.02%
Covered Lines: 6797
Relevant Lines: 6933

💛 - Coveralls

@@ -40,6 +40,9 @@ export interface ColumnOptions
/** 分组字段,优先级高于 seriesField , isGroup: true 时会根据 groupField 进行分组。*/
readonly groupField?: string;

// 自定义相关
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注释用多行注释

@hustcc hustcc merged commit 5a22da6 into master Oct 21, 2021
@hustcc hustcc deleted the feat-column branch October 21, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants