Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme preview workflow broken #3013

Closed
qwerty541 opened this issue Jul 29, 2023 · 5 comments · Fixed by #3017 or #3034
Closed

Theme preview workflow broken #3013

qwerty541 opened this issue Jul 29, 2023 · 5 comments · Fixed by #3017 or #3034
Labels
bug Something isn't working. github_actions Pull requests that update GitHub Actions code high-priority High priority issue or PR. themes Feature, Enhancement, Fixes related to themes.

Comments

@qwerty541
Copy link
Collaborator

Theme preview workflow is currently broken. most likely because recent dependencies updates. Error can be found there:
@qwerty541 qwerty541 added bug Something isn't working. themes Feature, Enhancement, Fixes related to themes. high-priority High priority issue or PR. github_actions Pull requests that update GitHub Actions code labels Jul 29, 2023
@rickstaa
Copy link
Collaborator

Looks like the GraphQL API got updated, and the createReview method is no longer found 🤔.

https://github.com/anuraghazra/github-readme-stats/blob/79545927f19c19dbe7a874e4b48ca2b7982e7571/scripts/preview-theme.js#L203C9-L209

Wil check later what the new syntax is 👍🏻.

@qwerty541 qwerty541 linked a pull request Jul 30, 2023 that will close this issue
CI: Fix theme preview workflow #3017
Merged
@qwerty541
Copy link
Collaborator Author

qwerty541 commented Aug 1, 2023 •
edited
Loading

@rickstaa Merging #3017 improved sutiation since previous error gone but not resolved the whole problem. At least workflow added review and labels to my PR with test theme #3028. Currently it fails with another unexpected error: https://github.com/anuraghazra/github-readme-stats/actions/runs/5721747511/job/15503797772

Please take a look if you have a time or i will later.

@qwerty541 qwerty541 reopened this Aug 1, 2023
@qwerty541
Copy link
Collaborator Author

@rickstaa I have opened #3034 with second attempt to fix error. Looks like i missed one place with .rest property ti insert.

@qwerty541 qwerty541 linked a pull request Aug 2, 2023 that will close this issue
CI: Fix theme preview workflow (Attempt 2) #3034
Merged
@rickstaa rickstaa reopened this Aug 2, 2023
@qwerty541
Copy link
Collaborator Author

@rickstaa Theme preview workflow currently works: #3028

@rickstaa
Copy link
Collaborator

rickstaa commented Aug 2, 2023

Great thanks for solving this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. github_actions Pull requests that update GitHub Actions code high-priority High priority issue or PR. themes Feature, Enhancement, Fixes related to themes.
Projects
None yet
Milestone
No milestone
2 participants
@rickstaa @qwerty541