New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix spammy duplicate confirmation log #1236

Closed

AshwinSekar opened this issue May 7, 2024 · 0 comments · Fixed by #1237

Assignees

AshwinSekar commented May 7, 2024

Problem

solana-labs#34014 introduced a new log line and metric when a frozen bank gets duplicate confirmed through replay votes for descendants.

This log line is improperly gated behind a check for supermajority confirmation, leading to the same slots being logged multiple times:

➜  grep "validator fork duplicate confirmed \d+" -o solana-validator.log | wc -l
35144511
➜  grep "validator fork duplicate confirmed \d+" -o solana-validator.log | sort -u | wc -l
111807

The text was updated successfully, but these errors were encountered:

AshwinSekar self-assigned this

AshwinSekar mentioned this issue

replay: do not recheck duplicate confirmation if already confirmed #1237

Merged

AshwinSekar closed this as completed in #1237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment