Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMOS check for time_coverage_min/max allows too wide margin of error #690

Open
mhidas opened this issue May 9, 2017 · 0 comments
Open
Assignees

Comments

@mhidas
Copy link
Contributor

mhidas commented May 9, 2017

The IMOS checker uses a comparison like np.isclose(time_max, time_coverage_end) to determine whether the global attributes match the range of values in the TIME variable. With the default parameters of np.isclose and typical values of the time variable, this will accept a difference of up to 5.5 hours between the two.

Since the global attributes are specified to the nearest second, the margin of error should be reduced to about 1 second.

@mhidas mhidas self-assigned this May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant