Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout issues with Gihub Enterprise auth enabled #11290

Closed
srthok opened this issue Oct 6, 2020 · 6 comments
Closed

Logout issues with Gihub Enterprise auth enabled #11290

srthok opened this issue Oct 6, 2020 · 6 comments

Comments

@srthok
Copy link

srthok commented Oct 6, 2020

Apache Airflow version: 1.10.9

Environment:

  • Cloud provider or hardware configuration: AWS
  • OS (e.g. from /etc/os-release): Ubuntu 18.04.4 LTS
  • Kernel (e.g. uname -a): Linux ip-x-x-x-x 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP x86_64 GNU/Linux
  • Install tools: Flask-OAuthlib (0.9.6)
  • Others:

What happened:
After configuring GHE auth, Login is working as expected and when I hit logout, It says as below and still can see DAGs and able to run DAGs

image

What you expected to happen:

 It should invalidate the session and take you  back to the login page

How to reproduce it:

Just by enabling GHE auth in airflow..

Here is what my config looks like..
<
[webserver]
authenticate = True
auth_backend = airflow.contrib.auth.backends.github_enterprise_auth
[github_enterprise]
host = github.xxxxx.yyyyy
client_id = xxxxxxxx
client_secret = xxxxxxx
oauth_callback_route = /admin/ghe_oauth/callback
allowed_teams = 32,947,948,682

Anything else we need to know:

It occurs all the time. I just followed the documentation to configure..http://airflow.apache.org/docs/stable/security.html#oauth-authentication

@srthok srthok added the kind:bug This is a clearly a bug label Oct 6, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 6, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@mik-laj
Copy link
Member

mik-laj commented Oct 6, 2020

Non-RBAC is no longer supported and we plan to drop support for it in Airflow 2.0. Non-RBAC UI now only gets security fixes. I'm afraid no contributor is interested in fixing other bugs and adding new features. I recommend migrating to RBAC and then configuring OAuth2 again.
See:
https://github.com/apache/airflow/blob/master/UPDATING.md#drop-legacy-ui-in-favor-of-fab-rbac-ui
https://airflow.readthedocs.io/en/latest/security/access-control.html
https://flask-appbuilder.readthedocs.io/en/latest/security.html

@mik-laj mik-laj added the area:webserver Webserver related Issues label Oct 8, 2020
@srthok
Copy link
Author

srthok commented Oct 16, 2020

Thanks for the info..I enabled rbac..I need to enable Oauth( GHE) and really appreciate if you can point me to any related documentation to enable GHE auth or sample confg file.Thanks

@jykae
Copy link

jykae commented Nov 18, 2020

@srthok check out https://issues.apache.org/jira/browse/AIRFLOW-4470

I was able to configure GHE with RBAC based on Cooper Gillan's comment

@mik-laj I hope this will go to documentation at some point ☝️

@eladkal
Copy link
Contributor

eladkal commented Oct 10, 2021

@jykae would you be interested in updating the documentation?

@jykae
Copy link

jykae commented Oct 12, 2021

@jykae would you be interested in updating the documentation?

@eladkal Sorry, can't remember enough to write docs about this, and would it work with current version 🤷‍♂️

Switched to use local DB auth, as we had this issue also with GHE auth #12782
Though we are still looking for centralized authentication solution for our installation.

@apache apache locked and limited conversation to collaborators Jun 20, 2022
@eladkal eladkal converted this issue into discussion #24561 Jun 20, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

4 participants