Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airflow db check-migrations -t 0 fails to check migrations in airflow 2.3 #24060

Closed
1 of 2 tasks
thesuperzapper opened this issue May 31, 2022 · 5 comments · Fixed by #24068
Closed
1 of 2 tasks

airflow db check-migrations -t 0 fails to check migrations in airflow 2.3 #24060

thesuperzapper opened this issue May 31, 2022 · 5 comments · Fixed by #24068
Labels
area:core kind:bug This is a clearly a bug

Comments

@thesuperzapper
Copy link
Contributor

Apache Airflow version

2.3.1 (latest released)

What happened

As of Airflow 2.3.0 the airflow db check-migrations -t 0 command will ALWAYS think there are unapplied migrations (even if there are none to apply), whereas, in Airflow 2.2.5, a single check would be run succeessfully.

This was caused by PR #18439, which updated the loop from while True (which always loops at least once) to for ticker in range(timeout) (which will NOT loop if timeout=0).

What you think should happen instead

No response

How to reproduce

No response

Operating System

All

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@uranusjr
Copy link
Member

uranusjr commented Jun 1, 2022

cc @ephraimbuddy

@ephraimbuddy
Copy link
Contributor

#24068

@potiuk
Copy link
Member

potiuk commented Jun 1, 2022

The PR is failing with #24037

@potiuk
Copy link
Member

potiuk commented Jun 1, 2022

I think we have to do something about the bitnami flakines @ephraimbuddy @jedcunningham - I'd love your opinions on the direction we could take.

@ephraimbuddy
Copy link
Contributor

I think we have to do something about the bitnami flakines @ephraimbuddy @jedcunningham - I'd love your opinions on the direction we could take.

I like the idea of hosting the postgres chart on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants