Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ENTER key correctly in trigger form and allow manual JSON #42525

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle ENTER key correctly in trigger form and allow manual JSON #42525

wants to merge 1 commit into from
+30 −2

Conversation

jscheffl
Copy link
Contributor

Follow-up of #42487

related: #42157

Unfortunately a bit more JavaScript is needed but this enables:

  • Handling of press of ENTER in input fields and ensure that JSON form is submitted and correct value is sent
  • Handling of manual changes of JSON dict (fix before: was always over-writing JSON)

@dannyl1u - can you confirm from your side?

@jscheffl jscheffl added the area:UI Related to UI/UX. For Frontend Developers. label Sep 26, 2024
@jscheffl jscheffl added this to the Airflow 2.10.3 milestone Sep 26, 2024
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Sep 26, 2024
@jscheffl jscheffl added type:bug-fix Changelog: Bug Fixes and removed area:webserver Webserver related Issues labels Sep 26, 2024
@dannyl1u
Copy link
Contributor

Follow-up of #42487

related: #42157

Unfortunately a bit more JavaScript is needed but this enables:

  • Handling of press of ENTER in input fields and ensure that JSON form is submitted and correct value is sent
  • Handling of manual changes of JSON dict (fix before: was always over-writing JSON)

@dannyl1u - can you confirm from your side?

Taking a look

@dannyl1u
Copy link
Contributor

@jscheffl tested your branch locally, works good for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers. type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 2.10.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jscheffl @dannyl1u