Restructure WatchedSubprocess and CommsDecoder for reuse in DagParsing #44874
+96
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes introduced here lets these existing classes serve "double" duty in the execution time of TaskSDK and also the Parse Time in the DAG Processor (but the actual switch to use these will be a separate bigger PR). There are a few warts here, namely: - The default on `CommsDecoder`'s decoder argument is incorrect for subclasses, we might fix that later to be more dynamic about the default. - The location of this code is not right for reuse in TaskSDK/execution time and parse time. There is a bigger bit of work being planned to move this all around before release of Airflow 3
kaxil
approved these changes
Dec 12, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Dec 13, 2024
apache#44874) The changes introduced here lets these existing classes serve "double" duty in the execution time of TaskSDK and also the Parse Time in the DAG Processor (but the actual switch to use these will be a separate bigger PR). There are a few warts here, namely: - The default on `CommsDecoder`'s decoder argument is incorrect for subclasses, we might fix that later to be more dynamic about the default. - The location of this code is not right for reuse in TaskSDK/execution time and parse time. There is a bigger bit of work being planned to move this all around before release of Airflow 3 - Some of the functions on the base WatchedSubprocess class are TI specific and maybe should be on a separate subclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced here lets these existing classes serve "double" duty in
the execution time of TaskSDK and also the Parse Time in the DAG Processor
(but the actual switch to use these will be a separate bigger PR).
There are a few warts left here, namely:
CommsDecoder's decoder argument is incorrect forsubclasses, we might fix that later to be more dynamic about the default.
and parse time. There is a bigger bit of work being planned to move this all
around before release of Airflow 3
WatchedSubprocessclass are TI specificand maybe should be on a separate subclass