Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor error log for manager api #678

Closed
4 tasks
nic-chen opened this issue Nov 3, 2020 · 6 comments
Closed
4 tasks

chore: refactor error log for manager api #678

nic-chen opened this issue Nov 3, 2020 · 6 comments
Labels
backend enhancement New feature or request
Milestone

Comments

@nic-chen
Copy link
Member

nic-chen commented Nov 3, 2020

relate to #620

  • Currently only panic logs are retained, errors are just respond by apis. we need to retain error logs.
  • Support custom error log level
  • Support saving to a local file, and can customize the file path
  • Support log rotate

we could use zap that most gophers recommend.

@nic-chen nic-chen added backend enhancement New feature or request labels Nov 3, 2020
@membphis
Copy link
Member

membphis commented Nov 3, 2020

@nic-chen nic-chen added this to the 2.0 milestone Nov 3, 2020
@nic-chen nic-chen changed the title requirement: refactor error log for manager api feature: refactor error log for manager api Nov 3, 2020
@nic-chen nic-chen changed the title feature: refactor error log for manager api chore: refactor error log for manager api Nov 3, 2020
@nic-chen
Copy link
Member Author

nic-chen commented Nov 3, 2020

@membphis
it use github.com/sirupsen/logrus

zap is better than logrus for us, I'm sure about that.

@membphis
Copy link
Member

membphis commented Nov 3, 2020

nice @nic-chen ^_^

can you list some reason? We need to why.

@nic-chen
Copy link
Member Author

nic-chen commented Nov 4, 2020

nice @nic-chen ^_^

can you list some reason? We need to why.

it has almost the same feature and much faster. and it support atomic level, sampling .. etc advanced features

@membphis
Copy link
Member

membphis commented Nov 4, 2020

Nice got it. And I check the license, it is MIT, good for us too.

Please confirm whether it will introduce new dependent libraries and their licenses are acceptable.

@nic-chen
Copy link
Member Author

nic-chen commented Nov 6, 2020

done.

rotate should be done with access log feature or after that.

@nic-chen nic-chen closed this as completed Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants