Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: snowflake algorithm of the request-id plugin will generate massive logs if etcd down #9657

Closed
lingsamuel opened this issue Jun 14, 2023 · 0 comments · Fixed by #9715
Closed
Assignees
Labels
bug Something isn't working

Comments

@lingsamuel
Copy link
Member

lingsamuel commented Jun 14, 2023

Current Behavior

image

The error check doesn't cover the etcd down case. If etcd is unavailable, every request will retry thousands of times.
Also, in the request-id use case, the snowflake algorithm introduces an unnecessary (and probably shouldn't) dependency on etcd. `uuid' is good enough for this case. We are planning to remove it.

Steps to Reproduce

  1. run APISIX with request-id snowflake enabled
  2. create route with request-id plugin and snowflake as algorithm
  3. disable etcd
  4. request to the route

Environment

  • APISIX version (run apisix version): 3.3.0
@lingsamuel lingsamuel added the bug Something isn't working label Jun 19, 2023
@lingsamuel lingsamuel self-assigned this Jun 19, 2023
@moonming moonming moved this to 📋 Backlog in Apache APISIX backlog Jun 19, 2023
@lingsamuel lingsamuel moved this from 📋 Backlog to 🏗 In progress in Apache APISIX backlog Jun 26, 2023
@lingsamuel lingsamuel moved this from 🏗 In progress to 👀 In review in Apache APISIX backlog Jun 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Apache APISIX backlog Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant