Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: traffic-split plugin does not verify the UpstreamID is valid #9996

Closed
Nobilta opened this issue Aug 9, 2023 · 1 comment · Fixed by #10008
Closed

bug: traffic-split plugin does not verify the UpstreamID is valid #9996

Nobilta opened this issue Aug 9, 2023 · 1 comment · Fixed by #10008
Assignees
Labels
bug Something isn't working

Comments

@Nobilta
Copy link

Nobilta commented Aug 9, 2023

Current Behavior

when i use traffic-split on a route,if i use a not exist upstream id,it will not verify this upstream id is valid.
{ "uri": "/index.html", "plugins": { "traffic-split": { "rules": [ { "weighted_upstreams": [ { "upstream_id": "abcdefg",//this upstreamid is not exist,but this request will success "weight": 1 }, { "weight": 1 } ] } ] } }, "upstream_id": "abcdefg",//this upstreamid is not exist,but this request will failed }

Expected Behavior

No response

Error Logs

No response

Steps to Reproduce

set traffic-split plugin on route,and set a not exist upstreamid

Environment

  • APISIX version (run apisix version):3.3
  • Operating system (run uname -a):
  • OpenResty / Nginx version (run openresty -V or nginx -V):
  • etcd version, if relevant (run curl http://127.0.0.1:9090/v1/server_info):
  • APISIX Dashboard version, if relevant:
  • Plugin runner version, for issues related to plugin runners:
  • LuaRocks version, for installation issues (run luarocks --version):
@shreemaan-abhishek
Copy link
Contributor

I could reproduce this, let me bring a fix.

@Revolyssup Revolyssup added the bug Something isn't working label Aug 10, 2023
@Revolyssup Revolyssup moved this to 🏗 In progress in Apache APISIX backlog Aug 10, 2023
@shreemaan-abhishek shreemaan-abhishek moved this from 🏗 In progress to 👀 In review in Apache APISIX backlog Aug 16, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Apache APISIX backlog Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants