From d2ac2b2f275d732843923a528ee4c05dee9400f4 Mon Sep 17 00:00:00 2001 From: William Ayd Date: Fri, 14 Jul 2023 08:40:43 -0700 Subject: [PATCH] test(c/driver/sqlite): improve coverage for uint, tz (#901) --- c/driver/sqlite/sqlite_test.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/c/driver/sqlite/sqlite_test.cc b/c/driver/sqlite/sqlite_test.cc index f99697d9c1..3ab21fe3fa 100644 --- a/c/driver/sqlite/sqlite_test.cc +++ b/c/driver/sqlite/sqlite_test.cc @@ -189,12 +189,13 @@ class SqliteStatementTest : public ::testing::Test, void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpTest()); } void TearDown() override { ASSERT_NO_FATAL_FAILURE(TearDownTest()); } - void TestSqlIngestUInt64() { GTEST_SKIP() << "Cannot ingest UINT64 (out of range)"; } - void TestSqlIngestBinary() { GTEST_SKIP() << "Cannot ingest BINARY (not implemented)"; } - void TestSqlIngestTimestampTz() { - GTEST_SKIP() << "Cannot ingest TIMESTAMP WITH TIMEZONE (not implemented)"; + void TestSqlIngestUInt64() { + std::vector> values = {std::nullopt, 0, INT64_MAX}; + return TestSqlIngestType(NANOARROW_TYPE_UINT64, values); } + void TestSqlIngestBinary() { GTEST_SKIP() << "Cannot ingest BINARY (not implemented)"; } + protected: void ValidateIngestedTemporalData(struct ArrowArrayView* values, enum ArrowTimeUnit unit,