Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard make_null_array for CASE #222

Closed
alamb opened this issue Apr 29, 2021 · 0 comments · Fixed by #223
Closed

Use standard make_null_array for CASE #222

alamb opened this issue Apr 29, 2021 · 0 comments · Fixed by #223
Labels
datafusion Changes in the datafusion crate enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Apr 29, 2021

Noticed by @tustvold

The CASE implementation includes code to build an array of entirely NULL, but that function exists (now) in Arrow. We should use the one in arrow rather than our own version

  1. remove code duplication
  2. Improve data type support for Case statement by using standard Arrow
@alamb alamb added enhancement New feature or request datafusion Changes in the datafusion crate labels Apr 29, 2021
@alamb alamb mentioned this issue Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use standard make_null_array for CASE alamb/datafusion
1 participant
@alamb